Changeset 13

Timestamp:

08/29/08 22:25:15 (4 years ago)

Author:

tsuckowhomberg

Message:

• fixed: re-rendering rows would not work proper if a resize of the panel during buffering happened; "adjustVisibleRows()" skips recalculating the "rowIndex" property now if the livegrid is currently buffering
• fixed: "replaceLiveRows()" would not always calculate the exact range of rows to render; adjusted conditions to check for valid ranges

Location:

trunk

Files:

• CHANGELOG (modified) (1 diff)
• src/BufferedGridView.js (modified) (5 diffs)

trunk/CHANGELOG

@@ -1 @@
-Version 0.2rc1
+Version 0.2rc2
+29-August-2008
+
+- fixes:
+ - BufferedGridView.js: re-rendering rows would not work proper if a resize of the panel
+during buffering happened; "adjustVisibleRows()" skips recalculating the "rowIndex"
+property now if the livegrid is currently buffering. "replaceLiveRows()" would not always
+calculate the exact range of rows to render; adjusted conditions to check for valid ranges
+
+Version 0.2rc1
 29-August-2008
 

trunk/src/BufferedGridView.js

@@ -454 +454 @@
         }
 
-
         // adjust the number of visible rows and the height of the scroller.
         this.adjustVisibleRows();
         this.adjustBufferInset();
-
 
         this.onLayout(vw, vh);
@@ -1433 +1431 @@
         var cursorBuffer = cursor-this.ds.bufferRange[0];
 
+        // compute the last possible renderindex
+        var lpIndex = Math.min(cursorBuffer+this.visibleRows-1, this.ds.bufferRange[1]-this.ds.bufferRange[0]);
+
         // we can skip checking for append or prepend if the spill is larger than
         // visibleRows. We can paint the whole rows new then-
@@ -1438 +1439 @@
             this.mainBody.update(this.renderRows(
                 cursorBuffer,
-                cursorBuffer+this.visibleRows-1
+                lpIndex
             ));
         } else {
             if (append) {
                 this.removeRows(0, spill-1);
-
-                if (cursor+this.visibleRows-1 < this.ds.bufferRange[1]) {
-                    var html = this.renderRows(cursorBuffer+this.visibleRows-spill,
-                               cursorBuffer+this.visibleRows-1);
+                if (cursorBuffer+this.visibleRows-spill < this.ds.bufferRange[1]-this.ds.bufferRange[0]) {
+                    var html = this.renderRows(
+                        cursorBuffer+this.visibleRows-spill,
+                        lpIndex
+                    );
                     Ext.DomHelper.insertHtml('beforeEnd', this.mainBody.dom, html);
                 }
+
             } else {
                 this.removeRows(this.visibleRows-spill, this.visibleRows-1);
@@ -1562 +1565 @@
         this.visibleRows = visibleRows;
 
+        // skip recalculating the row index if we are currently buffering.
+        if (this.isBuffering) {
+            return;
+        }
         if (this.rowIndex + visibleRows > totalLength) {
             this.rowIndex     = Math.max(0, totalLength-visibleRows);
@@ -1568 +1575 @@
 
         this.updateLiveRows(this.rowIndex, true);
-
     },