Changeset 15

Timestamp:

08/30/08 02:36:55 (4 years ago)

Author:

tsuckowhomberg

Message:

• fixed: last row would not always be rendered proper if the end of records is reached and the panel would be resized so that more records are displayable
• enhancement: improved calculating the height of the buffer inset in both performance and functionality
• enhancement: component now working with Safari 3.1 under windows XP

Location:

trunk

Files:

• CHANGELOG (modified) (1 diff)
• src/BufferedGridView.js (modified) (4 diffs)

trunk/CHANGELOG

@@ -1 @@
-Version 0.2rc2
+Version 0.2rc3
+30-August-2008
+
+- fixes;
+ - BufferedGridView.js: last row would not always be rendered proper if the end of
+records is reached and the panel would be resized so that more records are displayable
+- enhancements:
+ - BufferedGridView.js: improved calculating the height of the buffer inset in both
+performance and functionality. Component now working with Safari 3.1 under Windows XP
+
+Version 0.2rc2
 29-August-2008
 

trunk/src/BufferedGridView.js

@@ -1483 +1483 @@
         // adjust the height of the scrollbar
 
-        var contHeight = this.liveScroller.dom.parentNode.offsetHeight +
+        var liveScrollerDom = this.liveScroller.dom;
+
+        var contHeight = liveScrollerDom.parentNode.offsetHeight +
                          (Ext.isGecko
                          ? ((ds.totalLength > 0 && scrollbar)
@@ -1491 +1493 @@
                             ? 0 : this.horizontalScrollOffset)))
 
-        this.liveScroller.dom.style.height = contHeight+"px";
+        liveScrollerDom.style.height = contHeight+"px";
 
         if (this.rowHeight == -1) {
             return;
         }
-
-        // calculate the spill of the inner layer.
-        // spillHeight will contain the number of pixels
-        // the inner layer exceeds the scrollbar
-        var spillHeight = ((this.rowHeight*ds.totalLength)+this.hdHeight)-contHeight;
 
         // hidden rows is the number of rows which cannot be
         // displayed and for which a scrollbar needs to be
-        // rendered. This does alsso take clipped rows into account
-        var hiddenRows = 0;
-        if (spillHeight > 0) {
-            hiddenRows = Math.ceil(spillHeight/this.rowHeight);
-        }
-
-        this.liveScrollerInset.style.height = contHeight+(hiddenRows*this.rowHeight)+"px";
+        // rendered. This does also take clipped rows into account
+        var hiddenRows = (ds.totalLength == this.visibleRows-this.rowClipped)
+                       ? 0
+                       : Math.max(0, ds.totalLength-(this.visibleRows-this.rowClipped));
+
+        this.liveScrollerInset.style.height = (hiddenRows == 0 ? 0 : contHeight+(hiddenRows*this.rowHeight))+"px";
     },
 
@@ -1552 +1548 @@
 
         this.rowClipped = 0;
-        if (this.rowHeight / 3 < (vh - (visibleRows*this.rowHeight))) {
+        // only compute the clipped row if the total length of records
+        // exceeds the number of visible rows displayable
+        if (totalLength > visibleRows && this.rowHeight / 3 < (vh - (visibleRows*this.rowHeight))) {
             visibleRows = Math.min(visibleRows+1, totalLength);
             this.rowClipped = 1;
         }
 
-        // adjusted condition to force rerendering of scrollbar if the
-        // toalLength is less than visibleRows
-        if (this.visibleRows == visibleRows) {
+        if (this.visibleRows == visibleRows - this.rowsClipped) {
             return;
         }
@@ -1569 +1565 @@
             return;
         }
-        if (this.rowIndex + visibleRows > totalLength) {
-            this.rowIndex     = Math.max(0, totalLength-visibleRows);
+        // when re-rendering, doe not take the clipped row into account
+        if (this.rowIndex + (visibleRows-this.rowClipped) > totalLength) {
+            this.rowIndex     = Math.max(0, totalLength-(visibleRows-this.rowClipped));
             this.lastRowIndex = this.rowIndex;
         }