Changeset 19

Timestamp:

08/31/08 23:18:43 (4 years ago)

Author:

tsuckowhomberg

Message:

• fixed: (BufferedGridView?.js) typo left in "insertRows()" would prevent the view to reassign the proper rowIndex when argument "isUpdate" was set to true
• fixed: (BufferedGridView?.js) wrong parameter passed to "buffer" and "beforebuffer" event caused listeners to use wrong number of visible rows in the grid

Location:

trunk

Files:

• CHANGELOG (modified) (1 diff)
• src/BufferedGridView.js (modified) (3 diffs)

trunk/CHANGELOG

@@ -1 @@
-Version 0.2rc4
+Version 0.2rc5
+31-August-2008
+
+- fixed:
+ - BufferedGridView.js: typo left in "insertRows()" would prevent the view to reassign
+the proper rowIndex when argument "isUpdate" was set to true
+ - BufferedGridView.js: wrong parameter passed to "buffer" and "beforebuffer" event caused
+listeners to use wrong number of visible rows in the grid
+
+
+Version 0.2rc4
 30-August-2008
 

trunk/src/BufferedGridView.js

@@ -938 +938 @@
         if (success === true) {
             this.fireEvent('buffer', this, this.ds, this.rowIndex,
-                Math.max(this.visibleRows, this.getRows().length),
+                Math.min(this.ds.totalLength, this.visibleRows-this.rowClipped),
                 this.ds.getTotalCount(),
                 options
@@ -1139 +1139 @@
 
 
-        if (!isUpdate === true) {
+        if (isUpdate === true) {
             var rows   = this.getRows();
             var cursor = this.rowIndex;
@@ -1365 +1365 @@
 
         this.fireEvent('beforebuffer', this, this.ds, index,
-                       this.visibleRows, this.ds.totalLength);
+                       Math.min(this.ds.totalLength, this.visibleRows-this.rowClipped),
+                       this.ds.totalLength
+        );
 
         this.ds.suspendEvents();