Changeset 35

Timestamp:

11/01/08 23:19:34 (4 years ago)

Author:

tsuckowhomberg

google:author:

tsuckowhomberg

Message:

• fixed: (EditorGridPanel?.js) call to "startEditing()" would throw error if the requested index in the view is not currently representing a record; overrode method for checking if record to edit is available
• enhancement: (GridView?.js) adjusted behavior of "ensureVisible()" to scroll a requested cell horizontally into view

Location:

trunk

Files:

• CHANGELOG (modified) (1 diff)
• src/EditorGridPanel.js (modified) (1 diff)
• src/GridView.js (modified) (3 diffs)

trunk/CHANGELOG

@@ -1 @@
-Version 0.3a3 (GPL)
+Version 0.3a4 (GPL)
+1-November-2008
+
+ - fixed: (EditorGridPanel.js) call to "startEditing()" would throw error if the
+requested index in the view is not currently representing a record; overrode
+method for checking if record to edit is available
+ - enhancement: (GridView.js) adjusted behavior of "ensureVisible()" to scroll a
+requested cell horizontally into view
+
+Version 0.3a3 (GPL)
 1-November-2008
 

trunk/src/EditorGridPanel.js

@@ -50 +50 @@
 
     /**
+     * Starts editing the specified for the specified row/column
+     * Will be cancelled if the requested row index to edit is not
+     * represented by data due to out of range regarding the view's
+     * store buffer.
+     *
+     * @param {Number} rowIndex
+     * @param {Number} colIndex
+     */
+    startEditing : function(row, col)
+    {
+        this.stopEditing();
+        if(this.colModel.isCellEditable(col, row)){
+            this.view.ensureVisible(row, col, true);
+            if (!this.store.getAt(row)) {
+                return;
+            }
+        }
+
+        return Ext.ux.grid.livegrid.EditorGridPanel.superclass.startEditing.call(this, row, col);
+    },
+
+    /**
      * Since we do not have multiple inheritance, we need to override the
      * same methods in this class we have overriden for

trunk/src/GridView.js

@@ -1158 +1158 @@
     {
         var xy = this.ensureVisible(row, col, hscroll);
+
         if (!xy) {
                 return;
                 }
+
                 this.focusEl.setXY(xy);
 
@@ -1202 +1204 @@
         var rowEl = this.getRow(row), cellEl;
 
+        if(!rowEl){
+            return;
+        }
+
         if(!(hscroll === false && col === 0)){
             while(this.cm.isHidden(col)){
@@ -1209 +1215 @@
         }
 
-        if(!rowEl){
-            return;
-        }
-
         var c = this.scroller.dom;
+
+        if(hscroll !== false){
+            var cleft = parseInt(cellEl.offsetLeft, 10);
+            var cright = cleft + cellEl.offsetWidth;
+
+            var sleft = parseInt(c.scrollLeft, 10);
+            var sright = sleft + c.clientWidth;
+            if(cleft < sleft){
+                c.scrollLeft = cleft;
+            }else if(cright > sright){
+                c.scrollLeft = cright-c.clientWidth;
+            }
+        }
+
 
         return cellEl ?