Changeset 4

Timestamp:

06/16/08 18:37:37 (4 years ago)

Author:

tsuckowhomberg

Message:

• enhancement: BufferedGridStore? - added overrride of getAt() method to translate the passed argument to the appropriate index in the model; updated sources to take overriden method into account

Location:

trunk

Files:

• CHANGELOG (modified) (1 diff)
• src/BufferedGridView.js (modified) (2 diffs)
• src/BufferedRowSelectionModel.js (modified) (3 diffs)
• src/BufferedStore.js (modified) (1 diff)

trunk/CHANGELOG

@@ -1 @@
-2008-05-29
-==========
-- fixed: wrong calculation in BufferedGridView.onLiveScroll (based on lastScrollPosition and actual 
+
+Version 0.1
+16-June-2008
+
+- enhancements:
+ - BufferedGridStore - added overrride of getAt() method to translate
+the passed argument to the appropriate index in the model; updated sources to take
+overriden method into account
+ - added cfg option "scrollDelay" in BufferedGridView for buffering calls to onLiveScroll 
+when scroll-event gets fired (thanks to Rich Waters)
+ - BufferedStore: removed custom applySort() implementation due to changes in findInsertIndex
+ - BufferedStore: changed findInsertIndex to use parent implementation first, then check 
+return value and adjust the index if needed
+ - BufferedStore/BufferedGridView: moved bufferRange-member to BufferedStore
+ - BufferedStore: optimized insert() method in BufferedStore
+ - allowed to add records at position "0" in grid (existing records get shifted down)
+ 
+- fixes:
+ - wrong calculation in BufferedGridView.onLiveScroll (based on lastScrollPosition and actual 
 scrollPosition) caused the view sometimes to not re-render some rows
-- fixed: provided bug fix for "ensureVisible: returned x-coordinate does not take the x-position
+ - provided bug fix for "ensureVisible: returned x-coordinate does not take the x-position
 of the gridpanel into account" (see http://extjs.com/forum/showthread.php?p=175331#post175331)
-- enhancement: added cfg option "scrollDelay" in BufferedGridView for buffering calls to onLiveScroll 
-when scroll-event gets fired (thanks to Rich Waters)
-
-
-2008-05-28
-==========
-- fixed: wrong calculation of last displayable row after removing a row caused selection-model
+ - wrong calculation of last displayable row after removing a row caused selection-model
 to get out of synch with the store's data
-
-2008-05-17
-==========
-- enhancement: BufferedStore: removed custom applySort() implementation due to changes in findInsertIndex
-- enhancement: BufferedStore: changed findInsertIndex to use parent implementation first, then check 
- return value and adjust the index if needed
-- enhancement: BufferedStore/BufferedGridView: moved bufferRange-member to BufferedStore
-- enhancement: BufferedStore: optimized insert() method in BufferedStore
-- fixed: when adding a record to the store on the fly, the ensureVisible-method
+ - when adding a record to the store on the fly, the ensureVisible-method
 would not work always corect afterwards
-- fixed: when adding records, a previously made selection would block selecting the
+ - when adding records, a previously made selection would block selecting the
 newly added record
- - enhancement: allowed to add records at position "0" in grid (existing records get shifted down)
-- fixed: skipped request for updateLiveRows in Ext.ux.grid.BufferedGridView.adjustVisibleRows
+ - skipped request for updateLiveRows in Ext.ux.grid.BufferedGridView.adjustVisibleRows
 when number of total records in store is less than the number of visible rows
-- fixed: request for buffering data in Ext.ux.grid.BufferedGridView.updateLiveRows() did
+ - request for buffering data in Ext.ux.grid.BufferedGridView.updateLiveRows() did
 not apply the property "lastOptions.params" to the params sent with the buffer-request
-
-

trunk/src/BufferedGridView.js

@@ -615 +615 @@
             
             var cInd = viewIndex-this.rowIndex;
-            var rec  = this.ds.getAt(lastPossibleRIndex);
+            var rec  = this.ds.getAt(this.rowIndex+this.visibleRows-1);
             
             // did we reach the end of the buffer range?
@@ -1007 +1007 @@
                 if (this.grid.selModel.bufferedSelections[index] === true) {
                     this.addRowClass(i, "x-grid3-row-selected");
-                    selections.add(ds.getAt(index-this.ds.bufferRange[0]));     
+                    selections.add(ds.getAt(index));     
                 }
                 this.fly(row).removeClass("x-grid3-row-over");

trunk/src/BufferedRowSelectionModel.js

@@ -286 +286 @@
             this.lastActive = false;
         }
-        var r = this.grid.store.getAt(index-this.grid.getStore().bufferRange[0]);
+        var r = this.grid.store.getAt(index);
         
         delete this.pendingSelections[index];
@@ -312 +312 @@
         if(this.last === index || this.locked || index < 0) return;// || index >= this.grid.store.getCount())) return;
         
-        //var r = this.grid.store.getAt(index);
-        var r = this.grid.store.getAt(index-this.grid.getStore().bufferRange[0]);
+        
+        var r = this.grid.store.getAt(index);
        
         if(this.fireEvent("beforerowselect", this, index, keepExisting, r) !== false){
@@ -341 +341 @@
     clearPendingSelection : function(index)
     {
-        var r = this.grid.store.getAt(index-this.grid.getStore().bufferRange[0]);   
+        var r = this.grid.store.getAt(index);   
         if (!r) {
             return;

trunk/src/BufferedStore.js

@@ -443 +443 @@
         Ext.ux.grid.BufferedStore.superclass.loadRecords.call(this, o, options, success);    
     },    
+    
+    /**
+     * Get the Record at the specified index.
+     * The function will take the bufferRange into account and translate the passed argument
+     * to the index of the record in the current buffer.
+     *
+     * @param {Number} index The index of the Record to find.
+     * @return {Ext.data.Record} The Record at the passed index. Returns undefined if not found.
+     */
+    getAt : function(index)
+    {
+        var modelIndex = index - this.bufferRange[0];
+        return this.data.itemAt(modelIndex);
+    },    
+    
 //--------------------------------------EMPTY-----------------------------------
     // no interface concept, so simply overwrite and leave them empty as for now