Changeset 8

Timestamp:

08/25/08 03:07:14 (4 years ago)

Author:

tsuckowhomberg

Message:

• fixed: wrong calculation of "start"-parameter for the buffer-request caused infinite loop. Adjusted calculation of return value in "getPredictedBufferIndex()" to always return correct value for "start"-parameter if the "nearLimit" property is greater than or equals to half of store's "bufferSize" property (fixes google issue 4)

Location:

trunk

Files:

• CHANGELOG (modified) (1 diff)
• src/BufferedGridView.js (modified) (3 diffs)

trunk/CHANGELOG

@@ -1 @@
-Version 0.1.1
+Version 0.1.2
+25-August-2008
+
+- fixes:
+ - BufferedGridView: wrong calculation of "start"-parameter for the buffer-request
+caused infinite loop. Adjusted calculation of return value in "getPredictedBufferIndex()"
+to always return correct value for "start"-parameter if the "nearLimit" property is greater
+than or equals to half of store's "bufferSize" property (fixes google issue 4)
+
+Version 0.1.1
 25-August-2008
 

trunk/src/BufferedGridView.js

@@ -1202 +1202 @@
         var lastRowIndex = Math.min(this.ds.totalLength-1,
                                     rowIndex + this.visibleRows);
+
         return (rowIndex     >= this.ds.bufferRange[0]) &&
                (lastRowIndex <= this.ds.bufferRange[1]);
@@ -1216 +1217 @@
     {
         if (!inRange) {
-            return Math.max(0, index-(2*this.nearLimit));
+            var dNear = 2*this.nearLimit;
+            return Math.max(0, index-((dNear >= this.ds.bufferSize ? this.nearLimit : dNear)));
         }
         if (!down) {
@@ -1316 +1318 @@
 
         var bufferOffset = this.getPredictedBufferIndex(index, inRange, down);
-        var fetchSize    = this.ds.bufferSize;
 
         if (!inRange) {